Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes spatial information compulsory when adding new node(s) #142

Merged
merged 13 commits into from
Nov 3, 2022

Conversation

ana-kop
Copy link
Contributor

@ana-kop ana-kop commented Aug 26, 2022

No description provided.

@ana-kop ana-kop linked an issue Aug 26, 2022 that may be closed by this pull request
@ana-kop ana-kop requested a review from KasiaKoz September 9, 2022 15:14
Copy link
Collaborator

@KasiaKoz KasiaKoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments there, but the reason I'm sending it back is the code duplication, genet is only growing so we have to be very pedantic about this stuff

genet/core.py Outdated Show resolved Hide resolved
genet/core.py Outdated Show resolved Hide resolved
genet/core.py Outdated Show resolved Hide resolved
tests/test_core_network.py Outdated Show resolved Hide resolved
genet/core.py Show resolved Hide resolved
@KasiaKoz KasiaKoz self-requested a review November 3, 2022 17:22
@KasiaKoz KasiaKoz merged commit 47cb6e0 into main Nov 3, 2022
@KasiaKoz KasiaKoz deleted the 121-require-node-spatial-information branch November 3, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make non-optional spatial information when adding nodes.
2 participants