-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation zhuzh-up: PT speed computation #147
Conversation
…valid stage on schedule level
…ay-values # Conflicts: # tests/test_core_network.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really quick and effective way to visualise and validate the speeds of the schedule :D I had a few questions in regards to the network factor:
- Why is it used instead of the actual length of the route / links?
- Would the idea be to adjust the network factor based on how windy the roads are in an area?
…lity outside of class method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good! I especially like the idea of having both the options of using the network factor and the route distance to calculate speed which could also be handy for quick visual validations. :D
Resolves: #145 - Add speed computation and checks
Nb. Part of a wider validation upgrade series. I'm leaving updating the notebook: 6.1. Validating Network: MATSim Specific to last in the series.