Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elevation script fixes #170

Merged
merged 4 commits into from
Apr 6, 2023
Merged

Elevation script fixes #170

merged 4 commits into from
Apr 6, 2023

Conversation

KasiaKoz
Copy link
Collaborator

@KasiaKoz KasiaKoz commented Apr 4, 2023

Fixes:

As a bonus:

  • gets rid of elevation_output_dir = os.path.join(output_dir, 'elevation') it's a needless extra folder (nothing gets saved anywhere else). User can decide if they want outputs saved to a folder called elevation or not

@KasiaKoz KasiaKoz requested a review from mfitz April 4, 2023 11:23
Copy link
Contributor

@mfitz mfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I think we say this every time, but it feels like we could do with some testing around the functionality in these scripts (which I think we've also talked about collecting into a CLI, right?).

@KasiaKoz
Copy link
Collaborator Author

KasiaKoz commented Apr 6, 2023

I think we say this every time, but it feels like we could do with some testing around the functionality in these scripts (which I think we've also talked about collecting into a CLI, right?).

yeah, it's been on the (jira) cards for a while (unfortunately I'm struggling to find the card right now - I already started matching up some example inputs to the scripts on the card)

@KasiaKoz KasiaKoz merged commit 4d9b2cc into main Apr 6, 2023
@KasiaKoz KasiaKoz deleted the elevation-script-fixes branch April 6, 2023 13:29
@mfitz
Copy link
Contributor

mfitz commented Apr 6, 2023

Dunno about Jira, but there is #127 @KasiaKoz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants