Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Docker image to fix hanging build #212

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

brynpickering
Copy link
Contributor

Fixes #211.

I've purged nodejs while I'm here, but the main fix is copying the repo into a subdirectory of root and then pip installing it.

@brynpickering
Copy link
Contributor Author

Docker image is building on AWS

Copy link
Contributor

@mfitz mfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, @brynpickering 👍

One of those where the investigation takes many painful hours, but the fix is a tiny one line change. I looked at that file URI and never even noticed that the root dir path was making it look weird.

rm -rf /var/lib/apt/lists/*

RUN curl -sL https://deb.nodesource.com/setup_17.x | bash -
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see this purged 👍

@brynpickering brynpickering merged commit 2fecae4 into main Dec 12, 2023
1 check passed
@brynpickering brynpickering deleted the fix-docker-image-build branch December 12, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker image not building due to move to pyproject.toml(?)
3 participants