-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reading java array type #216
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bug fix looks good, but I've queried the conversion from list to set - are we okay with losing duplicate elements? Can this cause a problem?
Also - is there an issue for this bug?
right now we're ok and that's the expected behaviour, we have an issue: #125 so it's known and if this becomes a problem we can start a debate there on what should happen
No, I only noticed it when I looked at another bug, that was documented: #156 |
Made an issue for the bug and updated the PR description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
=======================================
Coverage 92.08% 92.08%
=======================================
Files 37 37
Lines 6620 6620
Branches 1588 1588
=======================================
Hits 6096 6096
Misses 305 305
Partials 219 219 ☔ View full report in Codecov by Sentry. |
Fixes #220
The java array types were being read to a set with extra unnecessary characters.
E.g. given:
would be read to
This is now fixed to give:
Added a test to catch the problem:
![Screenshot 2023-12-18 at 18 10 04](https://private-user-images.githubusercontent.com/36536946/291376754-18c3bbfc-177a-4f73-9541-c84b6ff28feb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxNzMxNzcsIm5iZiI6MTczOTE3Mjg3NywicGF0aCI6Ii8zNjUzNjk0Ni8yOTEzNzY3NTQtMThjM2JiZmMtMTc3YS00ZjczLTk1NDEtYzg0YjZmZjI4ZmViLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDA3MzQzN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA2NzIzYmYxMGYzNTU0ZTNkNGM1Y2QwM2NlMDMyODQxY2U0MGZkYmRlMGJjNWM3YmNhNzY5YzRlYWU5ODBkYjkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.2ZJfWJ6C54HlPnkmAfXb7E5FUy9-NOjNHgUjzh_kINk)