Fix saving geodataframes with empty geometry #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anarcoteron
approved these changes
Feb 19, 2024
anarcoteron
approved these changes
Feb 19, 2024
anarcoteron
approved these changes
Feb 19, 2024
anarcoteron
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of filling empty values with a string:
"None"we just leave them empty and operate on the values in the columns that have values.I think this was likely added so that empty values would show up in kepler, as
Nonerather than disappearing completely. We don't use kepler much anymore, since it's not maintained anymore, and leaving the values empty is more true to the original geodataframe.