Bump boost version to enable Python 3.11 package builds #7445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.11 is not compatible with Boost Python <= 1.80 due to error with Py_TPFLAGS_HAVE_GC enum. Ref: boostorg/python#400 Fixes: arvidn#7265
arvidn
reviewed
May 26, 2023
| @@ -17,7 +17,7 @@ test-command = [ | |||
| [tool.cibuildwheel.macos.environment] | |||
| BOOST_BUILD_PATH = "/tmp/boost/tools/build" | |||
| BOOST_ROOT = "/tmp/boost" | |||
| BOOST_VERSION = "1.80.0" | |||
| BOOST_VERSION = "1.81.0" | |||
There was a problem hiding this comment.
Unsure what you mean? This is for the macos wheels
There was a problem hiding this comment.
I'm not very familiar with how the wheels are build, so I'm curious what logic looks at this constant and installs the corresponding version of boost.
There was a problem hiding this comment.
I'm not a fan of toml... Check the previous table for the macos boost install, this table is nested env vars for it
3 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.11 is not compatible with Boost Python <= 1.80 due to error with Py_TPFLAGS_HAVE_GC enum.
Ref: boostorg/python#400
Fixes: #7265