add test coverage for read_resume_data() #7610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…match the torrent metadata
arvidn
force-pushed
the
resume-data-test
branch
from
b13a573
to
c92fd63
Compare
arvidn
commented
Feb 17, 2024
| @@ -135,11 +135,6 @@ namespace { | |||
| { | |||
| ec = err; | |||
| } | |||
| else if (((ret.info_hashes.has_v1() && ret.info_hashes.v1 != ret.ti->info_hashes().v1) | |||
| || (ret.info_hashes.has_v2() && ret.info_hashes.v2 != ret.ti->info_hashes().v2))) | |||
There was a problem hiding this comment.
@glassez this is the same check as on line 128 (but inverted), so I moved the block to its else-block
There was a problem hiding this comment.
👍
I didn't even notice that info hash is calculated before torrent info is parsed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when v1 or v2 hashes do not match the torrent metadata