Add energy plot #108
Add energy plot #108
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #108 +/- ##
==========================================
- Coverage 86.04% 85.38% -0.66%
==========================================
Files 24 25 +1
Lines 2845 2874 +29
==========================================
+ Hits 2448 2454 +6
- Misses 397 420 +23 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
| filter_vars=None, | ||
| group=None, | ||
| coords=None, | ||
| sample_dims=None, |
There was a problem hiding this comment.
I don't think we want this. Sample dims should either be an input and passed downstream to plot_dist or if having flattened to sample is not to be supported here then we should hardcode it and check both chain and draw are present.
| pc_kwargs=pc_kwargs, | ||
| ) | ||
|
|
||
| plot_collection.add_legend("energy", loc="outside right upper") |
There was a problem hiding this comment.
I opened an issue for this, it won't work across backends yet: #109
| return plot_collection | ||
|
|
||
|
|
||
| def _get_energy_ds(dt): |
There was a problem hiding this comment.
I'll try to look at https://docs.xarray.dev/en/stable/generated/xarray.DataArray.diff.html and see if we can make all this a bit more direct. I think it will also break when getting transposed inputs
There was a problem hiding this comment.
I have to admit, that I spent more than I expected to write this part (and try alternatives) :-)
This is not working, because we have a
np.nanvalue📚 Documentation preview 📚: https://arviz-plots--108.org.readthedocs.build/en/108/