Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase tolerance pareto test #149

Merged
merged 1 commit into from
Dec 18, 2022
Merged

increase tolerance pareto test #149

merged 1 commit into from
Dec 18, 2022

Conversation

aloctavodia
Copy link
Contributor

test_distributions/test_mle fails too often for Pareto. This seems to be a limitation of the MLE estimation for this distribution (and we basically use SciPy for this). So, as a workaround, this PR increases the tolerance.

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2022

Codecov Report

Merging #149 (1353350) into main (a500512) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
+ Coverage   77.23%   77.26%   +0.03%     
==========================================
  Files          18       18              
  Lines        2170     2173       +3     
==========================================
+ Hits         1676     1679       +3     
  Misses        494      494              
Impacted Files Coverage Δ
preliz/tests/test_distributions.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aloctavodia aloctavodia merged commit 3e8a783 into main Dec 18, 2022
@aloctavodia aloctavodia deleted the pareto_test branch December 18, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants