Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HyperGeometric distribution #215

Merged
merged 8 commits into from
Feb 24, 2023

Conversation

aleicazatti
Copy link
Collaborator

@aleicazatti aleicazatti commented Feb 23, 2023

Description

Here's the problematic one @aloctavodia

Checklist

  • Code style is correct (follows pylint and black guidelines)
  • Includes new or updated tests to cover the new feature
  • New features are properly documented (with an example if appropriate)
  • Includes a sample plot to visually illustrate the changes (only for plot-related functions)

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2023

Codecov Report

Merging #215 (5d54fff) into main (98e17c0) will increase coverage by 0.15%.
The diff coverage is 97.36%.

@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
+ Coverage   83.82%   83.98%   +0.15%     
==========================================
  Files          26       26              
  Lines        3042     3078      +36     
==========================================
+ Hits         2550     2585      +35     
- Misses        492      493       +1     
Impacted Files Coverage Δ
preliz/distributions/__init__.py 100.00% <ø> (ø)
preliz/internal/distribution_helper.py 95.65% <ø> (ø)
preliz/tests/test_mle.py 100.00% <ø> (ø)
preliz/tests/test_quartile.py 100.00% <ø> (ø)
preliz/internal/optimization.py 98.73% <66.66%> (-0.63%) ⬇️
preliz/distributions/discrete.py 93.75% <100.00%> (+0.53%) ⬆️
preliz/tests/test_maxent.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aleicazatti aleicazatti changed the title [WIP] Add HyperGeometric distribution Add HyperGeometric distribution Feb 24, 2023
@aloctavodia aloctavodia merged commit 5442730 into arviz-devs:main Feb 24, 2023
@aleicazatti aleicazatti deleted the HyperGeometric branch February 24, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants