Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use absolute loss for optimize_moments #217

Merged
merged 1 commit into from
Feb 24, 2023
Merged

use absolute loss for optimize_moments #217

merged 1 commit into from
Feb 24, 2023

Conversation

aloctavodia
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2023

Codecov Report

Merging #217 (16006e9) into main (64ce0d3) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #217   +/-   ##
=======================================
  Coverage   84.02%   84.02%           
=======================================
  Files          26       26           
  Lines        3080     3080           
=======================================
  Hits         2588     2588           
  Misses        492      492           
Impacted Files Coverage Δ
preliz/tests/test_maxent.py 100.00% <ø> (ø)
preliz/internal/optimization.py 98.73% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aloctavodia
Copy link
Contributor Author

Merging as I have rerun the test locally and on GitHub a few times and none of them showed a mismatch for the Rice distribution.

@aloctavodia aloctavodia merged commit 5e50b7b into main Feb 24, 2023
@aloctavodia aloctavodia deleted the alt_loss branch February 24, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants