Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial support for MultiVariate Variables #224

Merged
merged 5 commits into from
Mar 10, 2023
Merged

Add initial support for MultiVariate Variables #224

merged 5 commits into from
Mar 10, 2023

Conversation

aloctavodia
Copy link
Contributor

This adds general support for Multivariate variables and implements Dirichlet and Multivariate Normal in particular. Both implementations omit some methods compared to univariate. This is partly because of the differences between these two types of distributions, but also because we should think about which methods of elicitation we really want to implement for Multivariate distributions and work from there. One big missing method is plot_interactive, this should be added in the following PR:

  • Code style is correct (follows pylint and black guidelines)
  • Includes new or updated tests to cover the new feature
  • New features are properly documented (with an example if appropriate)
  • Includes a sample plot to visually illustrate the changes (only for plot-related functions)

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2023

Codecov Report

Merging #224 (39534e2) into main (5fe1cac) will decrease coverage by 1.42%.
The diff coverage is 68.16%.

@@            Coverage Diff             @@
##             main     #224      +/-   ##
==========================================
- Coverage   84.41%   82.99%   -1.42%     
==========================================
  Files          26       29       +3     
  Lines        3259     3564     +305     
==========================================
+ Hits         2751     2958     +207     
- Misses        508      606      +98     
Impacted Files Coverage Δ
preliz/internal/plot_helper_multivariate.py 48.71% <48.71%> (ø)
preliz/distributions/distributions_multivariate.py 54.32% <54.32%> (ø)
preliz/distributions/continuous_multivariate.py 97.22% <97.22%> (ø)
preliz/distributions/__init__.py 100.00% <100.00%> (ø)
preliz/tests/test_distributions.py 100.00% <100.00%> (ø)
preliz/tests/test_plots.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@aleicazatti aleicazatti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions for some typos and small changes in docstrings.

preliz/distributions/continuous_multivariate.py Outdated Show resolved Hide resolved
preliz/distributions/continuous_multivariate.py Outdated Show resolved Hide resolved
preliz/distributions/continuous_multivariate.py Outdated Show resolved Hide resolved
preliz/distributions/continuous_multivariate.py Outdated Show resolved Hide resolved
preliz/distributions/continuous_multivariate.py Outdated Show resolved Hide resolved
preliz/distributions/continuous_multivariate.py Outdated Show resolved Hide resolved
preliz/distributions/continuous_multivariate.py Outdated Show resolved Hide resolved
preliz/distributions/continuous_multivariate.py Outdated Show resolved Hide resolved
preliz/distributions/continuous_multivariate.py Outdated Show resolved Hide resolved
preliz/distributions/continuous_multivariate.py Outdated Show resolved Hide resolved
aloctavodia and others added 3 commits March 10, 2023 16:48
Co-authored-by: Alejandro Icazatti <ale.icazatti@gmail.com>
Co-authored-by: Alejandro Icazatti <ale.icazatti@gmail.com>
Co-authored-by: Alejandro Icazatti <ale.icazatti@gmail.com>
@aloctavodia aloctavodia merged commit a4d3dbd into main Mar 10, 2023
@aloctavodia aloctavodia deleted the mv branch March 10, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants