Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tests for ppa #313

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Conversation

rohanbabbar04
Copy link
Contributor

Solves #131

Description

Added tests for ppa

  • Added test_ppa.py
  • Added ppa.ipynb

Checklist

  • Code style is correct (follows pylint and black guidelines)
  • Includes new or updated tests to cover the new feature
  • New features are properly documented (with an example if appropriate)
  • Includes a sample plot to visually illustrate the changes (only for plot-related functions)
  • Widget states have been properly saved (only for notebooks with widgets) see for details.

@rohanbabbar04
Copy link
Contributor Author

rohanbabbar04 commented Feb 8, 2024

@aloctavodia
I am getting errors when setting engine=bambi, is it because it is currently not fully implemented or I am doing something wrong..

pz.ppa(a_preliz_model,engine="bambi")

Ran into some errors while applying the method in the above manner.

@aloctavodia
Copy link
Contributor

The parser for Bambi is very brittle at this point. maybe better to skip it. But we should open and issue to don't forget to add it later.

@rohanbabbar04
Copy link
Contributor Author

Sure, Currently I have not added it
I will let you review this PR, then will open an issue for engine=bambi

Copy link
Contributor

@aloctavodia aloctavodia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aloctavodia aloctavodia merged commit 9a68697 into arviz-devs:main Feb 8, 2024
4 checks passed
@rohanbabbar04 rohanbabbar04 deleted the ppa-test branch February 8, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants