-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added beta mode tests #323
Conversation
@aloctavodia is this what you were broadly looking for? |
The beta distribution is defined on the 0-1 interval. So for any beta distribution 100% of the mass will necessarily be inside that interval. In other words it is not posible to define a beta distribution with a mass less than 1 if the lower bound is 0 and the upper bound is 1. |
Hi @nishant42491 Let me know if you need help. |
hey there, I was a bit confused about how to compare the values of the fitted distribution. maybe use the distribution parameters which we receive from maxent let me know what you think. Also, I have included a minor fix to the mode value error included in the beta_mode function. The function does not converge when mode = lower bound or mode = upper bound hence a strict inequality is needed for that case. |
i have tried to fix this in my latest commit. |
yea, you are right the dist parameters should be symmetric. I have added a fix for that. |
Almost there, you need to run black. You can install https://pre-commit.com/ and it will alert you of errors with linters before committing. |
yep, black seems to have fixed all the linting issues |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #323 +/- ##
==========================================
+ Coverage 83.31% 84.04% +0.72%
==========================================
Files 36 37 +1
Lines 4244 4262 +18
==========================================
+ Hits 3536 3582 +46
+ Misses 708 680 -28 ☔ View full report in Codecov by Sentry. |
I have also set the default plot keyword to True in Beta_Mode which should fix issue #325. I have linked the issue through the description of this PR. |
Description
This PR adds tests for beta_mode and makes changes to the beta call function interface.
resolves #325, resolves #320
Checklist