-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pymc support to predictive explorer #450
Add pymc support to predictive explorer #450
Conversation
sample_prior_predictive emits a message. saying "Samplig", plus a list of the sampled variables. We should disable that message. It is generated with the logging module. We should suppress it locally with a context manager, or disable it before sampling and enable it again after sampling. We need to do this to avoid messing up calls to |
It is not needed for this PR, but something to think about. We may want to try to guess the value of "engine", for instance for a pymc model we could inspect the source and detect the regex pattern for "with pm.Model() as" where the particle "pm." is something that can vary. For Bambi it should also be simple to detect it. We may want to keep the "engine" argument and default to "auto" or something similar, just in case our automatic detection fails |
Created a contextmanager to handle the logs generated during this step. |
Sounds good.... Let me create a new issue for this |
I am currently keeping the sampling pymc code separated from the preliz code, like it was discussed in the jupyter notebook. |
agreed, we can refactor and combine later. Something really easy to combine is the plotting part, right? |
Yes... |
Description
engine
to predictive_explorer.Checklist