Distributions Gallery: Add ExGaussian #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are the differences indicate a potential mistake somewhere or just two ways to express the same? Did you compare the mathematical expressions for the pdf and cdf with the code for them? Are |
|
I was checking. It seems they are equivalent. I dont' know if we should use the docstring/code expressions or the ones in Wikipedia. |
|
Not sure, probably match the code. |
aloctavodia
reviewed
Aug 5, 2024
Co-authored-by: Osvaldo A Martin <aloctavodia@gmail.com>
aloctavodia
reviewed
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
I tried to derive the PDF and CDF from the equations on the Wikipedia page using$\nu$ , but in the docstring of the distribution, the PDF expression is a little different.