-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marshall/mock urlopen #15
Conversation
Merge branch 'main' into marshall/mock_urlopen
…requests is part of the standard library?
Hmm I'm seeing that some checks are not successful here |
…ew error handling signal in image.open call
Yay I think we're passing all of the tests. Adding exception handling for |
…ked so hard to grow
pyproject.toml
Outdated
@@ -7,6 +7,7 @@ requires = [ | |||
"numpy", | |||
"pillow", | |||
"kneed", | |||
"requests" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not add requests as a package dependency, instead we could add it as a dev dependency like this:
[project.optional-dependencies]
dev = [
"black",
"pytest",
"pytest-cov",
"requests",
]
Also, add it to ci/requirements.txt, since that's what we actually install during CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh thought I had removed it from there..
…here since it's already listed in extras_require under 'dev'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you @mpkrass7, this was a great find!
Essentially I just added a couple of web urls to the unit tests and validated that they work. If they aren't valid urls, they won't be tested. Please don't make me make a unit test to assess if the check for url validity is itself valid.
Notes: