Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marshall/transparency method #19

Merged
merged 3 commits into from
May 30, 2022
Merged

Marshall/transparency method #19

merged 3 commits into from
May 30, 2022

Conversation

mpkrass7
Copy link
Collaborator

No description provided.

@mpkrass7 mpkrass7 requested a review from arvkevi May 29, 2022 21:44
@mpkrass7 mpkrass7 mentioned this pull request May 29, 2022
Closed
arvkevi
arvkevi requested changes May 29, 2022
View reviewed changes
Copy link
Owner

@arvkevi arvkevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion in the remove_transparent docstring.

src/img2cmap/convert.py Outdated Show resolved Hide resolved
src/img2cmap/convert.py Show resolved Hide resolved
@mpkrass7 mpkrass7 requested a review from arvkevi May 30, 2022 00:18
arvkevi
arvkevi approved these changes May 30, 2022
View reviewed changes
Copy link
Owner

@arvkevi arvkevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mpkrass7 🙌🏼

@mpkrass7 mpkrass7 merged commit 8ebbe00 into main May 30, 2022
@mpkrass7 mpkrass7 deleted the marshall/transparency_method branch May 30, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvkevi arvkevi arvkevi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpkrass7 @arvkevi