Make _usb_ctrl_transfer Python 3 compatible #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The data_or_wLength argument is of type 'str' in Pyhton 2, wheras it's 'bytes' in Python 3. Calling ord() to convert the character to binary unicode representation is therefore no longer needed on Python 3. This fixes issue #34 on Python 3 while retaining Python 2 compatibility
|
@arvydas Would it be possible for you to review this proposal? |
|
Thank you very much for this fix. Pushing an update to the library in a bit. |
Thanks. I've just submitted a follow-up doc update in #71. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
data_or_wLengthargument is of type'str'in Pyhton 2, whereas it's'bytes'in Python 3. Callingord()to convert the character to binary unicode representation is therefore no longer needed on Python 3.This fixes issue #34 on Python 3 while retaining Python 2 compatibility. Tested locally on Python 2.7 (32bit) and Python 3.7 (64bit).