Skip to content

Commit

Permalink
Remove cache.Options.Namespace and use cache.Options.Namespaces s…
Browse files Browse the repository at this point in the history
…lice
  • Loading branch information
ary1992 committed Jun 21, 2023
1 parent a51b1df commit d895168
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pkg/client/kubernetes/cache/single_object.go
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ func (s *singleObject) createAndStartCache(log logr.Logger, key client.ObjectKey
}

opts := s.opts()
opts.Namespace = key.Namespace
opts.Namespaces = []string{key.Namespace}
opts.DefaultFieldSelector = fields.SelectorFromSet(fields.Set{metav1.ObjectNameField: key.Name})
opts.ByObject = nil

Expand Down
2 changes: 1 addition & 1 deletion pkg/client/kubernetes/cache/single_object_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ var _ = Describe("SingleObject", func() {

mockCache = mockcache.NewMockCache(ctrl)
newCacheFunc := func(_ *rest.Config, opts cache.Options) (cache.Cache, error) {
Expect(opts.Namespace).To(Equal(obj.Namespace))
Expect(opts.Namespaces).To(ConsistOf(obj.Namespace))
Expect(opts.DefaultFieldSelector).To(Equal(fields.SelectorFromSet(fields.Set{"metadata.name": obj.Name})))
Expect(opts.ByObject).To(BeNil())
Expect(opts.Resync).To(Equal(resync))
Expand Down

0 comments on commit d895168

Please sign in to comment.