Skip to content

Commit

Permalink
Add inline documentation to domain specific methods
Browse files Browse the repository at this point in the history
Signed-off-by: patrickpa <patrick@ivex.ai>
  • Loading branch information
patrickpa committed Jun 12, 2024
1 parent 38bb331 commit 0493eee
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 2 deletions.
2 changes: 0 additions & 2 deletions qc_baselib/models/result.py
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,6 @@ class DomainSpecificInfoType(
name: str = attr(name="name")


# Add documentation about the implementation and link issue
# Add docs on public interface as well
class IssueType(
BaseXmlModel,
tag="Issue",
Expand Down
12 changes: 12 additions & 0 deletions qc_baselib/result.py
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,11 @@ def add_domain_specific_info(
domain_specific_info_name: str,
xml_info: List[etree._Element],
) -> None:
"""
The XML information list provided will be wrapped in the DomainSpecificInfo
tag and the information will be appended to the issue list of domain
specific information.
"""
bundle = self._get_checker_bundle(checker_bundle_name=checker_bundle_name)
checker = self._get_checker(bundle=bundle, checker_id=checker_id)
issue = self._get_issue(checker=checker, issue_id=issue_id)
Expand Down Expand Up @@ -441,6 +446,13 @@ def get_domain_specific_info(
checker_id: str,
issue_id: int,
) -> List[DomainSpecificInfoContent]:
"""
The method returns a list containing all relative DomainSpecificContent
dataclasses to the XML tags.
The XML information in each DomainSpecificInformation tag is unwrapped
and it is returned in a DomainSpecificContent dataclass.
"""
bundle = self._get_checker_bundle(checker_bundle_name=checker_bundle_name)
checker = self._get_checker(bundle=bundle, checker_id=checker_id)
issue = self._get_issue(checker=checker, issue_id=issue_id)
Expand Down

0 comments on commit 0493eee

Please sign in to comment.