Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the new result file schema #8

Merged
merged 11 commits into from
Jun 11, 2024
Merged

Support the new result file schema #8

merged 11 commits into from
Jun 11, 2024

Conversation

patrickpa
Copy link
Contributor

Description

This PR addresses the Result Schema updates in order to have the Python base library in sync with the latest schema.

Main changes

  1. Add metadata to the schema
  2. Add checker status to the schema
  3. Add rules definition to the schema
  4. Add addressed rules to checkers
  5. Add rule uid to issues
  6. Update Result public interface to take into account new schema
  7. Updated unit-test to include new schema

How was the PR tested?

  1. Unit-test are passing with the updates and additions.

Notes

  • None

patrickpa added 7 commits June 10, 2024 16:23
@patrickpa
Update Result model to match new schema
74ffe0c 
Signed-off-by: patrickpa <patrick@ivex.ai>
@patrickpa
Update Result public interface to support new schema
e8e56e8 
Signed-off-by: patrickpa <patrick@ivex.ai>
@patrickpa
Update tests to work with new schema restrictions
5410c96 
Signed-off-by: patrickpa <patrick@ivex.ai>
@patrickpa
Add test data for new schema
d197d5d 
Signed-off-by: patrickpa <patrick@ivex.ai>
@patrickpa
Add extra tests for rule uid regex
6ac9382 
Signed-off-by: patrickpa <patrick@ivex.ai>
@patrickpa
Set status as optional with default empty
7767057 
Signed-off-by: patrickpa <patrick@ivex.ai>
@patrickpa
Add extra test for unregistered rule id on issue registration
84e9737 
Signed-off-by: patrickpa <patrick@ivex.ai>
@patrickpa patrickpa requested a review from hoangtungdinh June 10, 2024 16:03
@patrickpa patrickpa self-assigned this Jun 10, 2024
patrickpa added 4 commits June 10, 2024 22:50
@patrickpa
Fix InertialLocation attributes types
4f165e1 
Signed-off-by: patrickpa <patrick@ivex.ai>
@patrickpa
Improve code readability and documentation
7a15d37 
Signed-off-by: patrickpa <patrick@ivex.ai>
@patrickpa
Update README with latest version
12167dc 
Signed-off-by: patrickpa <patrick@ivex.ai>
@patrickpa
Add issue id to readme
a187216 
Signed-off-by: patrickpa <patrick@ivex.ai>
hoangtungdinh
hoangtungdinh approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@hoangtungdinh hoangtungdinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @patrickpa

@hoangtungdinh hoangtungdinh changed the title Update schema based on new version Support the new result file schema Jun 11, 2024
@hoangtungdinh hoangtungdinh merged commit 75db6fc into develop Jun 11, 2024
7 checks passed
@hoangtungdinh hoangtungdinh deleted the patrick/update_schema_based_on_new_version branch June 11, 2024 11:34
hoangtungdinh pushed a commit that referenced this pull request Jun 18, 2024
@patrickpa @hoangtungdinh
Support the new result file schema (#8)
b9f60f6 
Signed-off-by: patrickpa <patrick@ivex.ai>
@hoangtungdinh hoangtungdinh mentioned this pull request Jun 18, 2024
Merged
hoangtungdinh pushed a commit that referenced this pull request Jun 18, 2024
@patrickpa @hoangtungdinh
Support the new result file schema (#8)
52d08e3 
Signed-off-by: patrickpa <patrick@ivex.ai>
Signed-off-by: Patrick Abrahão <patrickabrahao.pa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangtungdinh hoangtungdinh hoangtungdinh approved these changes

Assignees

@patrickpa patrickpa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrickpa @hoangtungdinh