Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced Jupyter badge with .NET Interactive badge #545 #616

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

mgnslndh
Copy link
Contributor

This is a fix for #545.

Do you want the updated .PDN? Perhaps it could be added to a new folder in the root /Assets or /Branding?

Please add the hacktoberfest-accepted label to this PR if you find it useful.

@WhiteBlackGoose
Copy link
Member

Nice, but where did you take that notebook from?

@mgnslndh
Copy link
Contributor Author

mgnslndh commented Oct 18, 2023

The notebook is from the dotnet/interactive repo that you linked in the description.

@WhiteBlackGoose
Copy link
Member

Ah, I see. Are we allowed to use it? Do we need to credit it somewhere?

@mgnslndh
Copy link
Contributor Author

The repo is licensed under MIT so I guess we're good if we give them credit where that makes sense.

@mgnslndh
Copy link
Contributor Author

Since AngouriMath is a library I think that attribution should be part of the documentation.

@WhiteBlackGoose
Copy link
Member

For future reference: we reference .NET Interactive here.

@WhiteBlackGoose WhiteBlackGoose added the hacktoberfest-accepted Required by Hacktoberfest rules label Oct 18, 2023
@WhiteBlackGoose WhiteBlackGoose merged commit 79490e3 into asc-community:master Oct 18, 2023
@WhiteBlackGoose
Copy link
Member

Thanks

@mgnslndh mgnslndh deleted the gh-545 branch October 20, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Required by Hacktoberfest rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants