Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a modules DSL block to configure converter and other component versions #348

Closed
ysb33r opened this issue Apr 20, 2019 · 0 comments
Closed

Use a modules DSL block to configure converter and other component versions #348

ysb33r opened this issue Apr 20, 2019 · 0 comments
Labels
2.x Issue related to the 2.x series enhancement
Milestone
2.2.0

Comments

@ysb33r
Copy link
Member

ysb33r commented Apr 20, 2019 •
edited
Loading

Looking forward to 3.0 it is best to configure PDF, Digram etc. in a modules block on the extension:

asciidoctorj {
   modules {
     // Configure via closure (Groovy-DSL only)
    pdf {
      version = '1.2.3'
    }

    // Configure via direct assignment (All DSLs)
   pdf.version = '1.2.3' 
 }
}

(Kotlin will use the dotted assignment version)

Existing methods should be marked as deprecated and warnigns messages printed if they are used.
@ysb33r ysb33r added enhancement 2.x Issue related to the 2.x series labels Apr 20, 2019
@ysb33r ysb33r changed the title Use a modules DSL nlock to confure converter and other component versions Use a modules DSL block to configure converter and other component versions Apr 20, 2019
@ysb33r ysb33r added this to the 2.2.0 milestone Apr 20, 2019
ysb33r added a commit to ysb33r/asciidoctor-gradle-plugin that referenced this issue Apr 20, 2019
@ysb33r
Configure component and converter versions in a modules block (asciid…
89b47a3 
…octor#348)
ysb33r added a commit to ysb33r/asciidoctor-gradle-plugin that referenced this issue Apr 20, 2019
@ysb33r
Configure component and converter versions in a modules block (asciid…
60303d2 
…octor#348)
ysb33r added a commit to ysb33r/asciidoctor-gradle-plugin that referenced this issue Apr 20, 2019
@ysb33r
Configure component and converter versions in a modules block (asciid…
996e003 
…octor#348)
ysb33r added a commit to ysb33r/asciidoctor-gradle-plugin that referenced this issue Apr 20, 2019
@ysb33r
Configure component and converter versions in a modules block (asciid…
c54bef1 
…octor#348)
ysb33r added a commit to ysb33r/asciidoctor-gradle-plugin that referenced this issue Apr 20, 2019
@ysb33r
Fix javadoc errors (asciidoctor#348)
29673a2
ysb33r added a commit to ysb33r/asciidoctor-gradle-plugin that referenced this issue Apr 20, 2019
@ysb33r
Fix javadoc errors (asciidoctor#348)
b554f0c
ysb33r added a commit to ysb33r/asciidoctor-gradle-plugin that referenced this issue Apr 20, 2019
@ysb33r
Fix javadoc errors (asciidoctor#348)
2d4b8f7
ysb33r added a commit to ysb33r/asciidoctor-gradle-plugin that referenced this issue Apr 21, 2019
@ysb33r
Configure component and converter versions in a modules block (asciid…
0e78f90 
…octor#348)

Also:
- Add Gradle 5.4 to test matrix
- Fix javadoc errors
This was referenced Apr 21, 2019
Merged
Closed
ysb33r added a commit to ysb33r/asciidoctor-gradle-plugin that referenced this issue Apr 25, 2019
@ysb33r
Configure component and converter versions in a modules block (asciid…
658f658 
…octor#348)

Also:
- Add Gradle 5.4 to test matrix
- Fix javadoc errors
ysb33r added a commit to ysb33r/asciidoctor-gradle-plugin that referenced this issue May 4, 2019
@ysb33r
Configure component and converter versions in a modules block (asciid…
8562936 
…octor#348)

Also:
- Add Gradle 5.4 to test matrix
- Fix javadoc errors
ysb33r added a commit to ysb33r/asciidoctor-gradle-plugin that referenced this issue May 4, 2019
@ysb33r
Configure component and converter versions in a modules block (asciid…
9a10908 
…octor#348)

Also:
- Add Gradle 5.4 to test matrix
- Fix javadoc errors
This was referenced May 4, 2019
Merged
Merged
@ysb33r ysb33r closed this as completed May 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.x Issue related to the 2.x series enhancement
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
1 participant
@ysb33r