Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly resolving target file location for block macros #447

Merged

Conversation

zeldigas
Copy link
Contributor

Fixes #446

@ggrossetie
Copy link
Member

Thanks, would it be possible to revert the version bump and add a test with an example that wasn't working?

@ggrossetie ggrossetie force-pushed the feature/fix_relative_resolution branch from 9bf183e to 977e3b3 Compare March 25, 2024 22:51
@ggrossetie
Copy link
Member

@zeldigas I rebased your branch on master because the CI was running the JavaScript build instead of the Ruby build 😒

@zeldigas
Copy link
Contributor Author

Thanks, would it be possible to revert the version bump and add a test with an example that wasn't working?

@ggrossetie I'll revert version bump, and will try to add test for issue. Will let you know if I have problem with the latter

@ggrossetie
Copy link
Member

@zeldigas let me know if you need or guidance on adding a test.

@zeldigas
Copy link
Contributor Author

@zeldigas let me know if you need or guidance on adding a test.

Thank you, I'll prepare change, but most likely tomorrow or on weekend. Workdays are usually stuffed with work activities.

@zeldigas
Copy link
Contributor Author

@ggrossetie test added

@ggrossetie
Copy link
Member

Looks good, thanks!

@ggrossetie ggrossetie merged commit c241477 into asciidoctor:master Mar 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid resolution of files in block macro for non-antora setup
2 participants