Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect handling of inline AsciiMath #84

Closed
GarkGarcia opened this issue May 22, 2020 · 4 comments
Closed

Incorrect handling of inline AsciiMath #84

GarkGarcia opened this issue May 22, 2020 · 4 comments

Comments

@GarkGarcia
Copy link
Contributor

GarkGarcia commented May 22, 2020

This a follow up to #82 (comment). I recently implemented AsciiMath support. It has just been released.

However, I now realize the asciimath inline macro is incorrectly handled. Basically, it is handled in exact the same way the latexmath inline macro is. That means the macro is not processing AsciiMath code, it's actually processing LaTeX directly. In other words, currently the asciimath inline macro is functionally equivalent to the latexmath inline macro. This is an error.

I'm working on a patch, but I may need some help on it. This issue was cause by my inability to comprehend how inline stem blocks are currently handled. I think I've now got things figured out, but I'd like someone to review the patch in detail to make sure the implementation is not broken again.

@GarkGarcia
Copy link
Contributor Author

It is also worth noting that the asciimath block macro is working correctly.

@GarkGarcia
Copy link
Contributor Author

This issue could be avoided in the future with the introduction of tests targeting the rendering of the asciimath inline and block macros.

@ProgramFan
Copy link
Contributor

We need to refactor the code now. After a lot of edits, the code is messay.

@GarkGarcia
Copy link
Contributor Author

Fixed on 050841e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants