Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the asciimath inline-macro processor #85

Merged
merged 2 commits into from
May 23, 2020

Conversation

GarkGarcia
Copy link
Contributor

This is a follow up to #84:

This a follow up to #82 (comment). I recently implemented AsciiMath support. It has just been released.

However, I now realize the asciimath inline macro is incorrectly handled. Basically, it is handled in exact the same way the latexmath inline macro is. That means the macro is not processing AsciiMath code, it's actually processing LaTeX directly. In other words, currently the asciimath inline macro is functionally equivalent to the latexmath inline macro. This is an error.

I'm working on a patch, but I may need some help on it. This issue was cause by my inability to comprehend how inline stem blocks are currently handled. I think I've now got things figured out, but I'd like someone to review the patch in detail to make sure the implementation is not broken again.

@GarkGarcia
Copy link
Contributor Author

The relevant commit is 3b4dfc3.

@ProgramFan ProgramFan merged commit 050841e into asciidoctor:master May 23, 2020
@GarkGarcia
Copy link
Contributor Author

@tstumm Please let me know when the patch gets released.

@GarkGarcia
Copy link
Contributor Author

@tstumm Please let me know when the patch gets released.

@tstumm @ProgramFan Any updates on this?

@ProgramFan
Copy link
Contributor

@tstumm Maybe a new release on rubygems?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants