Upgradte tests to JUnit5 #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replace Junit4 by JUnit5 v5.7.1 * Bump assertj to v3.19.0 * Bump mockito to v3.8.0 * Bumo lombok to v1.18.18
abelsromero
force-pushed
the
refactor/upgrade-to-juni5
branch
from
e6d6470
to
042239d
Compare
|
Note this started motivated by a security alert in the junit4 version used (4.13), but on closer look I saw the upgrade was trivial ✌️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a pull request and contributing to asciidoctor-maven-plugin!
What kind of change does this PR introduce? (check at least one)
What is the goal of this pull request?
Upgrade tests from JUnit 4 to Junit 5.
Are there any alternative ways to implement this?
No.
Are there any implications of this pull request? Anything a user must know?
No. Just need to validate tests run normally and coverage is reported.
Is it related to an existing issue?
Finally, please add a corresponding entry to CHANGELOG.adoc