Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove antora stuff for standalone deployed docs site #530

Merged
merged 2 commits into from
May 7, 2021

Conversation

uniqueck
Copy link
Member

Thank you for opening a pull request and contributing to asciidoctor-maven-plugin!

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Refactor
  • Build improvement
  • Other (please describe)

What is the goal of this pull request?
This pull request fixes #529 and correct start page for standalone documentation site on gh-pages.

Are there any alternative ways to implement this?
no

Are there any implications of this pull request? Anything a user must know?
no

Is it related to an existing issue?

  • Yes
  • No

Finally, please add a corresponding entry to CHANGELOG.adoc

@coveralls
Copy link

coveralls commented Apr 30, 2021

Coverage Status

Coverage remained the same at 81.827% when pulling ca8332a on uniqueck:main into c611bc7 on asciidoctor:main.

@abelsromero
Copy link
Member

Thanks for the notice! To tell the truth, the ghpages antora site was a temporal thing while setting up the final docs (https://docs.asciidoctor.org) and forgot about it. What we should probably do is remove it from our repo since the playbok is in https://github.com/asciidoctor/docs.asciidoctor.org. Including the gh-action and README link. When done I can disable the gh-pages branch.

Do you want to take on it?

PS: start_page points by default to ROOT:index.adoc iirc, at leas in https://docs.asciidoctor.org/maven-tools/latest/ seems to work fine.

@uniqueck
Copy link
Member Author

uniqueck commented May 4, 2021

Ok i can do it. I will cleanup all unnecessary stuff for this local gh-pages based on antora.

@uniqueck uniqueck changed the title fix start page for standalone deployed docs site remove antora stuff for standalone deployed docs site May 4, 2021
@uniqueck
Copy link
Member Author

uniqueck commented May 4, 2021

Hi @abelsromero, please have a look for this updated PR.

@abelsromero
Copy link
Member

abelsromero commented May 5, 2021

Thanks a lot! Iirc there are some links in the readme?

@uniqueck
Copy link
Member Author

uniqueck commented May 5, 2021

Oh a good hint, i check this.

@abelsromero
Copy link
Member

I think updating the :uri-docs: attribute should be enough.

@uniqueck
Copy link
Member Author

uniqueck commented May 6, 2021

Sorry for the delay, yesterday was no time. Thanks for the point with docs-uri.

@abelsromero
Copy link
Member

Sorry for the delay, yesterday was no time. Thanks for the point with docs-uri.

Sorry, I has some time and was reviewing thing, it was more a note to self than a push 😅

@abelsromero abelsromero merged commit 2a79b16 into asciidoctor:main May 7, 2021
@abelsromero
Copy link
Member

abelsromero commented May 7, 2021

Excellent, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing start page for standalone documentation site
3 participants