Replace usage of jruby DirectoryWalker with Java NIO API (#532) #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelsromero
reviewed
Jul 7, 2021
src/main/java/org/asciidoctor/maven/process/SourceDocumentFinder.java
Outdated
Show resolved
Hide resolved
abelsromero
reviewed
Jul 7, 2021
src/test/java/org/asciidoctor/maven/process/SourceDocumentFinderTest.java
Show resolved
Hide resolved
abelsromero
reviewed
Jul 7, 2021
|
Thanks a lot for the PR, keeping this things is important! The only important thing is the |
Co-authored-by: Abel Salgado Romero <abelromero@gmail.com>
|
I've updated the PR. I've integrated your solution to joining, added a few tests for file extensions and clarified the changelog entry. |
|
Great! Thanks a lot! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
What is the goal of this pull request?
Closes #532 by replacing the class in question with the Java NIO API
Are there any alternative ways to implement this?
There are lots of 3rd party libraries to do similar stuff, but I didn't want to rely on those in favor of Java's own NIO API.
Are there any implications of this pull request? Anything a user must know?
I'm not sure about the error handling at
SourceDocumentFinder(line 70). TheDirectoryWalkerdidn't throw an exception and I didn't want to introduce one, so I handled it that way. I don't know if this is what you'd expect. If you have any feedback on this, I'm happy to change it.Is it related to an existing issue?
Fixes #532