Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify where to configure the plugin #558

Merged
merged 2 commits into from
Dec 9, 2021

Conversation

simonnagl
Copy link
Contributor

Thank you for opening a pull request and contributing to asciidoctor-maven-plugin!

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Refactor
  • Build improvement
  • Other (please describe)

What is the goal of this pull request?

Clarify where to put the plugin section in pom.xml

Are there any alternative ways to implement this?

No.

Are there any implications of this pull request? Anything a user must know?

No.

Is it related to an existing issue?

  • Yes
  • No

Finally, please add a corresponding entry to CHANGELOG.adoc

People new to maven may not know where to put the plugin section. At least I was irritated if this is a build or a report plugin.
@abelsromero
Copy link
Member

Thanks!

@abelsromero abelsromero merged commit 7a0c6f8 into asciidoctor:main Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants