(v2.2.x) #763 missing breadcrumb in maven site module #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The document title is e.g. displayed in breadcrumbs.
|
CI is going to report failure in the signatures test in branch 2.2.x, I am ignoring this for now. The PR code is fine, I'll have another look in the night and merge. |
3 tasks
abelsromero
force-pushed
the
branch-v2.2.x/issue-763-missing-breadcrumb-in-maven-site-module
branch
from
82f4ef0
to
4683ee3
Compare
abelsromero
force-pushed
the
branch-v2.2.x/issue-763-missing-breadcrumb-in-maven-site-module
branch
from
4683ee3
to
b5b676a
Compare
8 tasks
abelsromero
deleted the
branch-v2.2.x/issue-763-missing-breadcrumb-in-maven-site-module
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#763
Extract document title, author(s) and conversion date from Asciidoctor to enrich maven site head and genereta breadcrumbs.
At the end, used
Asciidoctor.loadbecause it offers a unique way to obtain the data without manual parsing.Concerns about performaces are mitigated using
parse_header_only(parseHeaderOnlyin AsciidoctorJ API).