Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(main) Fix IMG tag closing in parser-doxia-module #930

Conversation

abelsromero
Copy link
Member

Thank you for opening a pull request and contributing to asciidoctor-maven-plugin!

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Refactor
  • Build improvement
  • Other (please describe)

What is the goal of this pull request?

Fix image tag not being closed in asciidoctor-parser-doxia-module.

Are there any alternative ways to implement this?

The solution delegates in the proper sink figureGraphics, we could have simply applied the change with rawText.
But I think is important to rely in raw as little as possible.

Are there any implications of this pull request? Anything a user must know?

Is it related to an existing issue?

  • Yes
  • No

Fixes #783

Finally, please add a corresponding entry to CHANGELOG.adoc

@abelsromero abelsromero merged commit 2e74161 into asciidoctor:main Oct 8, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IMG tag is not closed in Doxia Parser Module
1 participant