Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source location not reported if description in horizontal dlist is truncated #2502

Closed
mojavelinux opened this issue Mar 6, 2024 · 0 comments
Closed

Source location not reported if description in horizontal dlist is truncated #2502

mojavelinux opened this issue Mar 6, 2024 · 0 comments
Assignees
@mojavelinux
Labels
bug v2.3.14
Milestone
v2.3.x

Comments

@mojavelinux
Copy link
Member

If the description of a horizontal dlist is truncated because it exceeds the height of a single page, and the --sourcemap option is enabled when calling Asciidoctor PDF, the converter does not report the source location of the description. The reason this happens is because the value of the source_location property on the description block is not passed to the Prawn table cell object. The value of this property needs to be propagated to resolve this issue.
@mojavelinux mojavelinux added the bug label Mar 6, 2024
@mojavelinux mojavelinux added this to the v2.3.x milestone Mar 6, 2024
@mojavelinux mojavelinux self-assigned this Mar 6, 2024
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Mar 7, 2024
@mojavelinux
resolves asciidoctor#2502 propagate source location to table cell for…
3a5851b 
… description in horizontal dlist so it is included in truncation warning message
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Mar 7, 2024
@mojavelinux
resolves asciidoctor#2502 propagate source location to table cell for…
8a70306 
… description in horizontal dlist so it is included in truncation warning message
mojavelinux added a commit that referenced this issue Mar 7, 2024
@mojavelinux
backport fix for #2502 propagate source location to table cell for de…
cb8ce5b 
…scription in horizontal dlist so it is included in truncation warning message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mojavelinux mojavelinux

Labels
bug v2.3.14
Projects
None yet
Milestone
v2.3.x
Development

No branches or pull requests
1 participant
@mojavelinux