Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect asciidoctor.org/docs/asciidoctor-revealjs to docs.asciidoctor.org/reveal.js-converter/ #993

Closed
ggrossetie opened this issue Feb 2, 2021 · 4 comments · Fixed by #995

Comments

@ggrossetie
Copy link
Member

As the title says 😉

@ggrossetie ggrossetie changed the title Redirect asciidoctor.org/docs/asciidoctor-revealjs to docs.asciidoctor.org/reveal.js-converter Redirect asciidoctor.org/docs/asciidoctor-revealjs to docs.asciidoctor.org/reveal.js-converter/ Feb 2, 2021
@mojavelinux
Copy link
Member

I was actually holding off on doing this since I was thinking we should reserve this space as a project page. But as I thought about it more, I realized a) we need to get rid of the old page since it is creating confusion and b) if we do make project pages, they would use the path /projects rather than /docs. So basically, 👍.

If you'd like to try to mess with the make-shift URL router that we have, you should be able to preserve deep links. See https://github.com/asciidoctor/asciidoctor.org/blob/master/_ext/routers/convert-documents.js. The empty key is followed if no exact match can be made.

@mojavelinux mojavelinux transferred this issue from asciidoctor/docs.asciidoctor.org Feb 3, 2021
@mojavelinux
Copy link
Member

@Mogztter Do you plan to submit a PR to add this to the URL router?

Keep in mind that you do have to leave an empty page behind so that the URL router has something to attach to.

@ggrossetie
Copy link
Member Author

@mojavelinux Yes, it just slipped off my list, sorry 😅

@mojavelinux
Copy link
Member

No worries. I just happened to be grooming the asciidoctor.org repo looking for docs issues to fix ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants