Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reserve stable module names for future JPMS modularization #1240

Merged
merged 2 commits into from
Nov 11, 2023

Conversation

leadpony
Copy link
Contributor

@leadpony leadpony commented Nov 7, 2023

Kind of change

  • Bug fix
  • New non-breaking feature
  • New breaking feature
  • Documentation update
  • Build improvement

Description

The module names I picked are in accordance with those of OSGi bundles.
If you don't like the names, I will change them.

Issue

Fixes #1239

Release notes

I added a line to CHANGELOG.adoc.

Names are reserved as follows.
core: org.asciidoctor.asciidoctorj
api: org.asciidoctor.asciidoctorj.api
cli: org.asciidoctor.asciidoctorj.cli
@robertpanzer
Copy link
Member

Thank you!

@robertpanzer robertpanzer merged commit 989cf99 into asciidoctor:main Nov 11, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic-Module-Name is undefined in MANIFEST file
2 participants