Fixes #1265. Support setting column widths #1270
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a pull request and contributing to AsciidoctorJ!
Please take a bit of time giving some details about your pull request:
Kind of change
Description
What is the goal of this pull request?
Add support for setting the width of table columns.
While columns have a method
setWidth()
that sets the attributewidth
of a column, this does not become effective.In addition it is required to set the attribute
colpcwidth
, which Asciidoctor core only sets internally when calling Table#assign_column_widths.How does it achieve that?
This PR adds a method Table.assignColumnWidths which calls the Ruby method mentioned above.
Are there any alternative ways to implement this?
Very likely.
Are there any implications of this pull request? Anything a user must know?
There should be no change of existing behavior.
Issue
If this PR fixes an open issue, please add a line of the form:
Fixes #1265
This PR is a draft until more tests, in particular for the auto width_cols are added.
Release notes
Please add a corresponding entry to the file CHANGELOG.adoc