Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Java 23 compatibility with Error Prone #695

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

ascopes
Copy link
Owner

@ascopes ascopes commented Jun 21, 2024

A regression was created in the JDK 23 EA sources which breaks ErrorProne (see google/error-prone#4415).

Updating to 2.28.0 should fix this issue.

See google/error-prone#4415 for details.

Signed-off-by: Ashley <73482956+ascopes@users.noreply.github.com>
@ascopes ascopes added bug Something isn't working testing Improvements to test packs labels Jun 21, 2024
@ascopes ascopes self-assigned this Jun 21, 2024
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.32%. Comparing base (78256d2) to head (b33aaf3).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #695      +/-   ##
==========================================
- Coverage   88.36%   88.32%   -0.04%     
==========================================
  Files          97       97              
  Lines        3007     3007              
  Branches      244      244              
==========================================
- Hits         2657     2656       -1     
- Misses        303      304       +1     
  Partials       47       47              

see 1 file with indirect coverage changes

@ascopes ascopes merged commit b798e2c into main Jun 21, 2024
19 of 20 checks passed
@ascopes ascopes deleted the task/error-prone-java-23 branch June 21, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working testing Improvements to test packs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant