Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-393: Use tiered level-1 compilation when running JVM subprocesses #395

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

ascopes
Copy link
Owner

@ascopes ascopes commented Sep 21, 2024

This PR introduces a couple of new flags in the JVM plugin scripts that enables tiered compilation that only runs at level 1 (client)
rather than level 2 (server) mode for JIT.

The idea here is to reduce the startup times for short-lived processes invoking JVM plugins internally.

Closes GH-393.

@ascopes ascopes added general improvements Fixing/updating internal components and code java labels Sep 21, 2024
@ascopes ascopes added this to the v2.6.x milestone Sep 21, 2024
@ascopes ascopes self-assigned this Sep 21, 2024
@ascopes ascopes marked this pull request as ready for review September 21, 2024 09:58
Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.31%. Comparing base (5739f74) to head (2d5cf6a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #395      +/-   ##
==========================================
+ Coverage   88.10%   88.31%   +0.22%     
==========================================
  Files          33       33              
  Lines        1100     1103       +3     
  Branches       79       79              
==========================================
+ Hits          969      974       +5     
+ Misses         96       95       -1     
+ Partials       35       34       -1     
Files with missing lines Coverage Δ
...protobufmavenplugin/plugins/JvmPluginResolver.java 89.02% <100.00%> (+0.38%) ⬆️

... and 1 file with indirect coverage changes

@ascopes ascopes merged commit 0d8cc05 into main Sep 21, 2024
15 checks passed
@ascopes ascopes deleted the task/GH-392 branch September 21, 2024 10:08
@ascopes ascopes linked an issue Sep 21, 2024 that may be closed by this pull request
@ascopes ascopes changed the title GH-392: Use tiered level-1 compilation when running JVM subprocesses GH-393: Use tiered level-1 compilation when running JVM subprocesses Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
general improvements Fixing/updating internal components and code
Projects
None yet
1 participant