Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression for Maven 3.8.2 in v2.9.0 #508

Merged
merged 3 commits into from
Dec 22, 2024

Conversation

ascopes
Copy link
Owner

@ascopes ascopes commented Dec 22, 2024

Fix regression for path parsing in Maven 3.8.2.

@ascopes ascopes added the bug Something isn't working label Dec 22, 2024
@ascopes ascopes added this to the v2.9.x milestone Dec 22, 2024
@ascopes ascopes self-assigned this Dec 22, 2024
@ascopes ascopes force-pushed the bugfix/maven-3.8.2-path-parsing branch from ecf153f to 6c52d43 Compare December 22, 2024 21:59
Copy link

codecov bot commented Dec 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.56%. Comparing base (f609750) to head (680f810).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #508   +/-   ##
=======================================
  Coverage   87.56%   87.56%           
=======================================
  Files          40       40           
  Lines        1310     1310           
  Branches       89       89           
=======================================
  Hits         1147     1147           
  Misses        122      122           
  Partials       41       41           
Files with missing lines Coverage Δ
...protobufmavenplugin/mojo/AbstractGenerateMojo.java 100.00% <100.00%> (ø)

Fix regression for path parsing in Maven 3.8.2.
@ascopes ascopes force-pushed the bugfix/maven-3.8.2-path-parsing branch from 6c52d43 to 86d80fa Compare December 22, 2024 22:11
@ascopes ascopes force-pushed the bugfix/maven-3.8.2-path-parsing branch from 7f56e7d to 680f810 Compare December 22, 2024 22:32
@ascopes ascopes merged commit bef93df into main Dec 22, 2024
10 of 11 checks passed
@ascopes ascopes deleted the bugfix/maven-3.8.2-path-parsing branch December 22, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant