fix: solved issue #31 - rate limit on GitHub API #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cj81499
suggested changes
May 21, 2022
| @@ -3,11 +3,7 @@ | |||
| set -eo pipefail | |||
|
|
|||
| cmd="curl --silent --location" | |||
There was a problem hiding this comment.
Since we're making changes around this area of the code, might I suggest we use curl -fsSL?
|
@smorimoto are you the right person to request to review this? |
Co-authored-by: Cal Jacobson <cj81499@users.noreply.github.com>
cj81499
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have a lot of skills with bash let alone regex. But I tried to solve the Issue #31.
As I explained at #26 (comment).
If you have something to improve, criticism is welcome!
.
.
.
p.s.: I don't know if this causes any issues related to the vulnerability. So please if you find something, don't accept the PR!