Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PDO pgsql for macOS with Homebrew and disable PCRE JIT for M1 #116

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

hlubek
Copy link

@hlubek hlubek commented Apr 4, 2022

  • Sets the libpq path configure option for macOS for PDO pgsql
  • Disables PCRE JIT for arm64 (e.g. Apple M1) because it doesn't work (yet)

With these fixes we were able to install PHP 7.4, 8.0 and 8.1 on macOS with Intel (older 10.15) and Apple Silicon (12.2), so it should work for a wider variety of OS versions.

ahawkins and others added 8 commits October 11, 2021 13:45
PHP does not compile on openssl@3. The "brew --prefix openssl" command
does not behave as expected. If openssl@1.1 is installed then it will
not output anything. If opsenssl@3 is installed then it will output a
prefix for openssl@3. This commit uses explicit 1.1 version of OpenSSL.

OpenSSL 3 was released to homebrew recently, so users may encounter this
issue after upgrading to newest versions.
@hlubek hlubek requested a review from a team as a code owner April 4, 2022 09:26
@Drarok
Copy link

Drarok commented Apr 5, 2022

This is just what I needed to get a working build of PHP working via asdf, thanks!

@SethHorsley
Copy link

@smorimoto any chance this could be merged?

@smorimoto
Copy link
Member

@hlubek Could you rebase this PR to base branch?

@hlubek
Copy link
Author

hlubek commented Sep 28, 2022

@smorimoto I'll rebase the change and have a look at it 👍

@hlubek
Copy link
Author

hlubek commented Sep 28, 2022

@smorimoto It should work now, I noticed that the logic for PHP_WITHOUT_PCRE_JIT was switched around somehow in 4d6388b . I fixed that and added an automatic detection for Arm-based Macs (M1, M2, ...) that have issues with PCRE JIT.

@lucaspbastos
Copy link

Any update on when we can see this merged? @smorimoto

Copy link

@albuquerque53 albuquerque53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, congratulations for the fix!

@smorimoto could you merge this, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

7 participants