Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error on missing packages #85

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

iloveitaly
Copy link
Contributor

As I mentioned here the ASDF_PKG_MISSING variable doesn't actually do anything. This change actually throws an error if a package is missing.

Also added a link to a blog post where I detail this out further.

@smorimoto
Copy link
Member

This does not work except on macOS.

@iloveitaly iloveitaly force-pushed the throw-error-on-missing-packages branch from caf1fba to ac57008 Compare May 20, 2021 20:46
@iloveitaly iloveitaly force-pushed the throw-error-on-missing-packages branch 10 times, most recently from 1ec7d3c to a853944 Compare May 21, 2021 02:32
@iloveitaly iloveitaly force-pushed the throw-error-on-missing-packages branch from a853944 to 5d6b22a Compare May 21, 2021 02:50
@iloveitaly
Copy link
Contributor Author

@smorimoto looks like the non-macos script wasn't building with libjpeg/libpng at all. I've fixed this and the build is working on all platforms.

Copy link
Contributor

@ahawkins ahawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for addressing this. This bothered me as well.

Copy link
Contributor

@ahawkins ahawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something to nudge users toward a solution.

bin/install Show resolved Hide resolved
Indicate which packages need to be installed via brew

Co-authored-by: Adam Hawkins <accounts@ahawkins.me>
@iloveitaly iloveitaly requested a review from a team as a code owner November 18, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants