Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter out releases with the 'app@' prefix from the latest-stable script #28

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

pepicrft
Copy link
Contributor

@pepicrft pepicrft commented Aug 24, 2024

Resolves: #27

After turning https://github.com/tuist/tuist into a monorepo, we have now two release tag schemes:

  • app@x.y.z: They represent app releases
  • x.y.z: They represent CLI releases

We adjusted the logic that's used for listing all the releases, but there's one scenario that we missed, and that causes using the version tuist@latest with Mise to fail trying to pull an app@x.y.z tag if an app release is the latest release.

@pepicrft pepicrft self-assigned this Aug 24, 2024
@pepicrft pepicrft requested a review from a team as a code owner August 24, 2024 13:17
Copy link
Contributor

@fortmarek fortmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably filter out any tag with the "@" character, so if we ever add more projects in the monorepo, we don't have to adjust this logic again.

@fortmarek fortmarek changed the title Filter out releases with the 'app@' prefix from the latest-stable script fix: filter out releases with the 'app@' prefix from the latest-stable script Aug 26, 2024
@fortmarek fortmarek merged commit 8d6fb84 into main Aug 26, 2024
5 of 6 checks passed
@fortmarek fortmarek deleted the fix-latest-stable branch August 26, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

failed to install tuist with mise
2 participants