remove test check for tag in fits schema #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 8, 2024
eslavich
reviewed
Feb 12, 2024
asdf/_tests/test_schema.py
Outdated
| @@ -837,7 +837,7 @@ def test_schema_resolved_via_entry_points(): | |||
| schema_uris = extension_manager.get_tag_definition(tag).schema_uris | |||
| assert len(schema_uris) > 0 | |||
| s = schema.load_schema(schema_uris[0], resolve_references=True) | |||
| assert tag in repr(s) | |||
| assert schema_uris[0] in repr(s) | |||
There was a problem hiding this comment.
I might be confused, but shouldn't the URI be present in the id field?
assert s["id"] == schema_uris[0]There was a problem hiding this comment.
You're spot on and your checking the id is an improvement to the test. I updated the test to use your suggestion.
braingram
force-pushed
the
no_fits_tag
branch
from
64a5842 to
5f9f708
Compare
braingram
force-pushed
the
no_fits_tag
branch
from
5f9f708 to
008ae38
Compare
eslavich
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update
test_schema_resolved_via_entry_pointsto not check for atagentry in thefitsschema. Thetagis not required and this test is preventing it's removal in:asdf-format/asdf-standard#421
Checklist: