Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Node.js 16 #484

Closed
Kurt-von-Laven opened this issue Oct 11, 2022 · 4 comments · Fixed by #488
Closed

Upgrade to Node.js 16 #484

Kurt-von-Laven opened this issue Oct 11, 2022 · 4 comments · Fixed by #488
Assignees

Comments

@Kurt-von-Laven
Copy link

This repository uses Node.js 12 actions, which are deprecated. GitHub Actions recently began adding the following annotation warning all users of asdf-vm/actions:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: asdf-vm/actions

jthegedus pushed a commit that referenced this issue Nov 16, 2022
Co-authored-by: James Hegedus <jthegedus@hey.com>
Fixes #484
@jthegedus
Copy link
Contributor

jthegedus commented Nov 16, 2022

Hi all, sorry for the delay here. We have merged the PR #488 which resolved these issues.

As far as releasing this specific change goes, I want to re-jig the GitHub Releases to follow the automation we have in our other repos, so until a tagged version becomes available, I will ask you all to use the commit reference style:

steps:
  - name: asdf_install
    uses: asdf-vm/actions/install@6844d09
	# Reference a specific commit (most strict)

Where the SHA is the commit from master after the merge.

NOTE: an update to the min version of Node is considered a breaking API change to the Action, so this will release under tag 2.x

@Kurt-von-Laven
Copy link
Author

@jthegedus, it might be worth either creating issue(s) for the changes to the release process so that others can help if they are able or manually releasing this change. GitHub announced their intention to migrate Node.js 12 actions to Node.js 16 around June-August 2023, which could potentially be needlessly disruptive if all doesn't go smoothly for everyone.

@jthegedus jthegedus self-assigned this Jan 10, 2023
@jthegedus
Copy link
Contributor

@Kurt-von-Laven As part of my upcoming updates to this repo the release process will follow the same as the core asdf repo so any core member can release with a simple PR merge. Updating this repo is top of my priority list, so when I get a chance in the coming weeks this will be addressed.

@Kurt-von-Laven
Copy link
Author

Thank you! It's greatly appreciated.

@jthegedus jthegedus mentioned this issue Jan 10, 2023
SaphiraNgocThuy pushed a commit to SaphiraNgocThuy/actions that referenced this issue Feb 14, 2023
Co-authored-by: James Hegedus <jthegedus@hey.com>
Fixes asdf-vm#484
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants