docs: fix example workflow running twice for PR commit pushes #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, this seems fine to me. As an FYI I am reworking this repo to reduce maintenance and improve accessibility to contribute. As an aside, I also no longer recommend the scheduled runs as GitHub would automatically disable after X amount of consecutive runs without changes to the git tree. |
jthegedus
approved these changes
Dec 9, 2022
jthegedus
changed the title
|
I've personally never found scheduled runs to be useful. The CI builds I typically run are locked down enough that nothing breaks between commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this issue on a couple projects - the checks would run twice when a commit was pushed to an already opened PR.
With the changes here the workflow is triggered for PR updates (e.g. a PR opened or new commit pushed) OR when a new commit is pushed to the
mainbranch. Restricting pushes to the main branch ensures checks only run once per PR commit.