Don't assume that the RUBYLIB environment variable exists
#259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When run under asdf-direnv with direnv's `strict_env` set to true, then this script will run with bash's `nounset` enabled, which will cause this script to crash in the following way: ./exec-env:6: RUBYLIB: unbound variable (see asdf-community/asdf-direnv#115 for details) I know this doesn't affect regular asdf users, but this seems like a reasonable change to make, I hope you'll accept it!
|
Looks good to me as well! Thanks for the PR @jfly ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When run under asdf-direnv with direnv's
strict_envset to true, thenthis script will run with bash's
nounsetenabled, which will causethis script to crash in the following way:
(see asdf-community/asdf-direnv#115 for
details)
I know this doesn't affect regular asdf users, but this seems like a
reasonable change to make, I hope you'll accept it!