Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asdf latest command should defer to plugin to determine latest version #763

Closed
Stratus3D opened this issue Jul 13, 2020 · 2 comments · Fixed by #938
Closed

asdf latest command should defer to plugin to determine latest version #763

Stratus3D opened this issue Jul 13, 2020 · 2 comments · Fixed by #938

Comments

@Stratus3D
Copy link
Member

Is your feature request related to a problem? Please describe.

The asdf latest command assumes versions listed by the list-all command are semantic versions. This assumption is not necessarily correct for all plugins and could cause problems.

Describe the solution you'd like

The asdf latest should invoke a plugin callback named latest-stable when one is present to compute the latest version. If the latest-stable script is missing the asdf latest command should fallback to computing the latest version as it does now by assuming the versions are semantic versions.

Describe workarounds you've considered

None. This seems to be the most straightforward solution to this problem.

Additional context

This is actually what was requested for #216 but was never properly implemented.

@jthegedus jthegedus added this to the v0.9.0 milestone Sep 8, 2020
@jthegedus
Copy link
Contributor

Will this also resolve #648 ?

@threkk
Copy link
Contributor

threkk commented May 9, 2021

I have the same issue here. I am working on a plugin for age and even if age is stable enough for being recommended to use with sops among other use cases, the command asdf latests fails (and therefore, the pipeline) as all the versions are tagged with rc or beta. Having the change of explicitly declaring which one is the latest stable version would allow the plugin to work.

Edit: After looking into it, the feature seems straightforward. If none is able to pick it up, I volunteer to try to implement it.

threkk added a commit to threkk/asdf-age that referenced this issue May 11, 2021
This would fix the issue stated at asdf-vm/asdf#763
threkk added a commit to threkk/asdf that referenced this issue May 11, 2021
If the command `latest-stable` exists in the plugin, `asdf latest`
defers to it to determine the latest stable version.

Fixes asdf-vm#763
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants